Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Dub version to fix createMany error #18591

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

steven-tey
Copy link
Contributor

What does this PR do?

Upgrade dub version to fix createMany error (@see: dubinc/dub#1876)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Test both cases where all 3 links are valid vs 2 valid links + 1 invalid link to make sure it works as expected

Copy link

vercel bot commented Jan 10, 2025

@steven-tey is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team January 10, 2025 16:53
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 10, 2025
@graphite-app graphite-app bot requested a review from a team January 10, 2025 16:53
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Bump Dub version to fix createMany error". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added the ⬆️ dependencies Pull requests that update a dependency file label Jan 10, 2025
Copy link

graphite-app bot commented Jan 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/10/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/10/25)

1 label was added to this PR based on Keith Williams's automation.

PeerRich
PeerRich previously approved these changes Jan 10, 2025
@PeerRich PeerRich enabled auto-merge (squash) January 10, 2025 16:56
Copy link

socket-security bot commented Jan 10, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@keithwillcode keithwillcode changed the title Bump Dub version to fix createMany error chore: Bump Dub version to fix createMany error Jan 10, 2025
Copy link
Contributor

E2E results are ready!

@zomars
Copy link
Member

zomars commented Jan 10, 2025

Seems like API V2 is breaking https://github.com/calcom/cal.com/actions/runs/12713782361/job/35444795473?pr=18591

Can you verify? @supalarry

auto-merge was automatically disabled January 10, 2025 20:55

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants