[feat] style view-plants #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
utils/helpers.ts
Outdated
| @@ -227,3 +227,26 @@ export function formatTimestamp(timestamp: string): string { | |||
| // Return in MM/DD/YYYY format | |||
| return `${month}/${day}/${year}`; | |||
| } | |||
| export function mapMonthToSeason(month: string): string { | |||
| month = processPlantMonth(month).toUpperCase(); | |||
| const monthToSeason: { [key: string]: string } = { | |||
There was a problem hiding this comment.
maybe we can move this map outside the function in case we need to use it elsewhere?
| align-items: center; | ||
| width: 136px; | ||
| `; | ||
| export const PlantImage = styled.img` |
There was a problem hiding this comment.
i think we should be using styled(NextImage) instead of styled.img
Comment on lines
+17
to
+19
| 0 24px 38px 3px rgb(148, 181, 6, 0.14), | ||
| 0 9px 46px 8px rgb(148, 181, 6, 0.12), | ||
| 0 11px 15px -7px rgb(148, 181, 6, 0.2)` |
There was a problem hiding this comment.
checking w/ kyrene if we want this!
| background: none; | ||
| border: none; | ||
| color: ${COLORS.shrub}; | ||
| font-family: inherit; |
There was a problem hiding this comment.
this should be by default!
Comment on lines
+24
to
+27
| font-size: 16px; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| line-height: normal; |
There was a problem hiding this comment.
note, this should be a styled(P1), which would handle the font styling for you. then, you can use HeaderButton with as="button", i.e.
<HeaderButton as="button"> </HeaderButton>
Pull the latest commits on main to see the P1 style in styles/text.ts!
…rap-garden into style-view-plants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
PlantCarda memoized component: this prevents unnecessary re-renders whenfilteredPlantListchanges, but the plants themselves don't change.styles/containers.tsfor generic Box and Flex containersScreenshots
My Garden
All Plants
How to review
/view-plants,components/PlantCard/Next steps
styling
RoundCheck)functionality
Relevant links
Online sources
Related PRs
CC: @ccatherinetan