-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] view plants: created PlantCard component #4
[feat] view plants: created PlantCard component #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Would it be possible to create an instance of this component in the app/view-plants
directory to test it out?
Also make sure to run npm run lint
and npm run prettier:fix
before you push to pass the styling checks!
@@ -0,0 +1,52 @@ | |||
.Card { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for starting the initial styling! can we migrate these styles to Styled Components?
see kevin's pr for reference on using Styled Components!
Styled components doc: https://styled-components.com/
Here's a styles.tsx
file reference from IJP: https://github.com/calblueprint/immigration-justice-project/blob/main/src/components/ListingDetails/styles.ts
* update sort order, use pnpm, update styles * update README * update workflow
0 24px 38px 3px rgba(0, 0, 0, 0.14), | ||
0 9px 46px 8px rgba(0, 0, 0, 0.12), | ||
0 11px 15px -7px rgba(0, 0, 0, 0.2); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-top-left-radius: 12px; | ||
border-top-right-radius: 12px; | ||
} | ||
.cardContent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would probably change anyways when you switch to styled components but style class names should use Pascal Case (e.g. CardContent) instead of Camel Case (but this is a small thing lol)
great work! i think the final changes are
|
743b29b
to
1077750
Compare
What's new in this PR 🧑🌾
Description
The main changes were adding the plant card component and supabase function call (the function that is called in this file is also viewable on supabase)
Screenshots
Rough styling --still need to add icons, etc
How to review
Next steps
Relevant links
Online sources
https://stackoverflow.com/questions/55688418/what-is-a-non-setof-function-in-postgresql
Related PRs
CC: @ccatherinetan