Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] implements add plant details #18
[feat] implements add plant details #18
Changes from all commits
d986a81
cb5c73a
7e6a572
6cbfb12
2a645b8
daad21a
6466397
ad2bce4
4f8e04a
e12e4e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing
document.getElementById
we can use a useState to track the dateInput and plantingType, i.e.(you might be able to handle the null cases differently, but this is just a suggestion)
And then, pass the value and the setValue func (e.g. plantingType, setPlantingType) into
PlantDetails
(see the later comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will cause a type error once we change
planting_type
toPlantingTypeEnum
(instead ofstring
) inschema.d.ts
. Hopefully the additional value/setValue handling (see other comments) will resolve the the type errorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design question @kyrenetam: do we want to hide (or rename) the "Back" button on the first add plant screen page? I feel like it's misleading, unless we plan to allow users to route back to
view-plants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should take in
setDate
andsetPlant
See Kyle's FilterDropdown in
components/FilterDropdown.tsx
for an example of how to pass in setState react hooksSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be
PlantingTypeEnum
you should also have
export type PlantingTypeEnum = 'INDOORS' | 'OUTDOORS' | 'TRANSPLANT'