Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Implement Plant Seasonality Filters #17
[feat] Implement Plant Seasonality Filters #17
Changes from 5 commits
9214578
8fbc20f
6ca499b
33bea10
f57e7c5
1811a59
9fc4041
533409c
787573c
d38ca1c
e63c387
7cea03d
1935f34
164db4a
de99f08
37a7173
15429e2
b008660
b8deff7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm wondering if we need to modify the logic here. what if the growing season is Summer, but the indoor time is April-Sept (i.e. it includes all Summer months, but the start and end times are not in the summer months), and outdoors is August-August? I don't think this example would realistically happen, but we also have to account for
LATE_MONTH
values which aren't included in thegrowingSeasonToMonth
map.Perhaps we should try to all seasons that the growing season elapses and check if the inputted
growing_season
is in the list of elapsed seasons.Perhaps using actual enums might help here? (The type enums that we're using rn are just types and not actual enums oops)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i rlly like this structure! it's super clean; great job!
quick note: in the next sprint we'll add a state filter too