feat: qr code scanner #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
christophertorres1
requested changes
Oct 30, 2024
…r-city-forest into apawar/ocf-12-qr-scanner
…r-city-forest into apawar/ocf-12-qr-scanner
|
should be ready for review @christophertorres1 |
christophertorres1
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Adding a page for QR code scanning with expo-camera. After scanning a QR code, it takes you to the placeholder Tree Info Page where it shows you the "id" of the tree you just scanned.
Also added some boilerplate for react-navigation to pass params like the tree id between pages.
Screenshots
QR Code Scanner:
How to review
Use a QR Code generator (like this) and add a tree id as the value. Scan the QR code and see if it gets the correct data from the QR code, and navigates you to the tree info page.
Next steps
Make everything look pretty!
Relevant links
Online sources
https://docs.expo.dev/versions/latest/sdk/camera/
https://reactnavigation.org/docs/typescript/#type-checking-screens
Related PRs
None
CC: @christophertorres1