[feat] add nonprofits to the site #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinkang-0
reviewed
Jan 10, 2024
|
Hey Sam, is it possible for you to convert the images into WEBP format instead? (here's a tool that does that) I'm uncertain if Astro's image optimizations will apply for background images, but please let me know if I'm wrong! |
jinkang-0
reviewed
Jan 11, 2024
jinkang-0
reviewed
Jan 11, 2024
jinkang-0
reviewed
Jan 11, 2024
jinkang-0
reviewed
Jan 11, 2024
Comment on lines
+1
to
+3
| --- | ||
| const { name, description, image, startColor, endColor, url } = Astro.props; | ||
| --- |
There was a problem hiding this comment.
nit: can you add Typescript definitions for Props? here's an example from the docs
|
|
||
| .card:hover { | ||
| transform: scale(1.05); | ||
| transition: transform .225s ease-in-out; |
There was a problem hiding this comment.
can we add this transition to the default card itself? it looks a bit odd when you unhover a card as the transition is removed
jinkang-0
changed the title
allisonhongberkeley
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
lgtm for initial deployment, @sampoder can you address these comments still?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
WIP!