Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] update SCSS imports & update client directive for nav #3

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[refactor] update SCSS imports & update client directive for nav #3

merged 1 commit into from
Jan 5, 2024

Conversation

jinkang-0
Copy link
Collaborator

What's new?

  • Update SCSS import to use default namespace
  • Update SCSS variable files to be partials
  • Update NavBar usage in Header to use client:media directive instead to better suit what it's for

@linear Linear
Copy link

linear bot commented Jan 5, 2024

HTB-4 Clean up code

Update to use better Astro and SCSS conventions

@jinkang-0 jinkang-0 changed the title [refactor] update SCSS imports & update client directive for nav bar [refactor] update SCSS imports & update client directive for nav Jan 5, 2024
@jinkang-0 jinkang-0 merged commit 380f43e into main Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jinkang-0