Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] make clean up edits #25

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Conversation

jinkang-0
Copy link
Collaborator

@jinkang-0 jinkang-0 commented Jan 12, 2024

What's new?

New:

  • Made navbar links underline on hover
  • Add links to each sponsor

Optimizations:

  • Made sponsor images higher res
  • Optimize about images (lower res)

Edits:

  • Modify NPO card animation and sizing (only bg image scales; sizing more consistent with Figma)
  • Shift section ID to header tag (for consistent navigation)
  • Extend animation time on Hero title to be 5 seconds (1s/word)
  • Add breakpoint to FAQ - one column on mobile

Miscellaneous:

  • Rename about images
  • Prep each section for importing graphics
    • Section content fills horizontal screen space

Linear Task

https://linear.app/hack-for-impact-2024/issue/HFI-37/make-clean-up-edits

@jinkang-0 jinkang-0 requested a review from oahnh January 12, 2024 07:12
Copy link
Member

@oahnh oahnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for styling for the breakpoints! Just two comments, but otherwise lgtm!

src/components/Contact.astro Show resolved Hide resolved
src/components/Hero.astro Show resolved Hide resolved
@jinkang-0 jinkang-0 requested a review from oahnh January 12, 2024 20:32
@jinkang-0 jinkang-0 merged commit a71bc58 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants