Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] about section: about us and image carousel #18

Merged
merged 16 commits into from
Jan 12, 2024
Merged

[feat] about section: about us and image carousel #18

merged 16 commits into from
Jan 12, 2024

Conversation

me-liu
Copy link
Contributor

@me-liu me-liu commented Jan 11, 2024 •
edited
Loading

What's new?

  • about us and image carousel
Screenshot 2024-01-11 at 10 26 51 AM

Linear Task

https://linear.app/hack-for-impact-2024/issue/HFI-14/about-section

@me-liu me-liu changed the title Melissa/about about section: about us and image carousel Jan 11, 2024
jinkang-0
jinkang-0 reviewed Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few suggestions on the current state, but things are heading towards a good direction!

src/components/About.astro Outdated Show resolved Hide resolved
src/components/About.astro Outdated Show resolved Hide resolved
src/components/About.astro Outdated Show resolved Hide resolved
src/components/About.astro Outdated Show resolved Hide resolved
@me-liu me-liu marked this pull request as draft January 11, 2024 19:47
@me-liu me-liu marked this pull request as ready for review January 11, 2024 20:40
@jinkang-0
Copy link
Collaborator

Remember to rebase off main!

jinkang-0
jinkang-0 reviewed Jan 11, 2024
View reviewed changes
src/components/About.astro Outdated Show resolved Hide resolved
src/components/About.astro Outdated Show resolved Hide resolved
src/components/About.astro Outdated Show resolved Hide resolved
@jinkang-0
Copy link
Collaborator

image

@jinkang-0 jinkang-0 changed the title about section: about us and image carousel [feat] about section: about us and image carousel Jan 12, 2024
allisonhongberkeley
allisonhongberkeley approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@allisonhongberkeley allisonhongberkeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the images are different sizes, so they load out of order than what's shown on the initial page load. we can fix this in a later iteration.

@allisonhongberkeley allisonhongberkeley merged commit f5dba20 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinkang-0 jinkang-0 jinkang-0 left review comments

@allisonhongberkeley allisonhongberkeley allisonhongberkeley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@me-liu @jinkang-0 @allisonhongberkeley