Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HFI-18] feat(faq): adds faq section #16

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Conversation

oahnh
Copy link
Member

@oahnh oahnh commented Jan 11, 2024

[HFI-18] FAQs Section

(sorry for the messy PR πŸ˜΅β€πŸ’« I linked changed files below)

What's new?

Screen.Recording.2024-01-11.at.12.25.28.AM.mov

TODOS:

  • create single-column layout for mobile

Linear Task

https://linear.app/hack-for-impact-2024/issue/HFI-18/faqs-section

oahnh and others added 7 commits January 11, 2024 00:18
* add graphics, button

* update global button style

* update button styles
* update navbar, h5 global style

* update navbar height
* add footer

* remove edit to env.d.ts

* use astro image for optimization

* remove edit to env.d.ts
* update hero

* update text styles, minor adjustment to hero layout

* remove changes to env.d.ts

* tell prettier to ignore env.d.ts

* tell lint to ignore env.d.ts

* update scroll behavior and padding

* microscopic edits

* add bouncing arrow
Copy link
Collaborator

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great progress!! I made a few nits and a couple of things to improve UX, but we should be set after iterations and rebasing!

src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQDropdown/style.module.scss Outdated Show resolved Hide resolved
src/components/FAQDropdown/style.module.scss Outdated Show resolved Hide resolved
src/components/FAQDropdown/index.tsx Outdated Show resolved Hide resolved
src/components/FAQDropdown/style.module.scss Outdated Show resolved Hide resolved
src/components/FAQDropdown/index.tsx Outdated Show resolved Hide resolved
ccatherinetan and others added 5 commits January 11, 2024 11:21
* create skeleton

* change div to section

* fill out Our Mission + Vision

* add and use b

* clean up / remove comments

* check style (prettier)

* remove b from global styles

* create div for mission and vision
@oahnh oahnh requested a review from jinkang-0 January 11, 2024 21:46
src/components/FAQ.astro Outdated Show resolved Hide resolved
src/components/FAQDropdown/index.tsx Outdated Show resolved Hide resolved
src/components/FAQDropdown/style.module.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@allisonhongberkeley allisonhongberkeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jinkang-0 jinkang-0 merged commit a34b071 into main Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants