add sponsors #15
Closed
add sponsors #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinkang-0
requested changes
Jan 11, 2024
src/components/Sponsors.astro
Outdated
|
|
||
| <div class="sponsors-container"> | ||
| <div class="image-container"> | ||
| <img src="/src/graphics/sponsors/citris.webp" /> |
There was a problem hiding this comment.
To add images, Astro recommends importing them via JavaScript so they can be optimized. Feel free to reference the official docs here or check out some existing code in the Hero component of main branch.
Additionally, please add an alt attribute to describe the image! This will let users know what the image is supposed to be in case they cannot access them.
src/components/Sponsors.astro
Outdated
Comment on lines
46
to
63
| h4 { | ||
| color: #3d3833; | ||
| font-weight: 400; | ||
| letter-spacing: 0.05rem; | ||
| } | ||
| h2 { | ||
| color: #3d3935; | ||
| font-weight: 500; | ||
| b { | ||
| color: #3d3935; | ||
| font-weight: 600; | ||
| } | ||
| } | ||
| p { | ||
| color: #3d3833; | ||
| font-weight: 500; | ||
| } | ||
| } |
There was a problem hiding this comment.
We've defined all these in the _global.scss file! You can just use the tags themselves and the styles should automatically apply!
src/components/Sponsors.astro
Outdated
| <section id="sponsors"> | ||
| <div class="header-container"> | ||
| <h4>SPONSORS & PARTNERS</h4> | ||
| <h2>A round of applause for our <b>past sponsors</b></h2> |
There was a problem hiding this comment.
styling: the <h2> here should be <h3> instead (which is a different font), and <b> should be <h2>
* update hero * update text styles, minor adjustment to hero layout * remove changes to env.d.ts * tell prettier to ignore env.d.ts * tell lint to ignore env.d.ts * update scroll behavior and padding * microscopic edits * add bouncing arrow
* create skeleton * change div to section * fill out Our Mission + Vision * add and use b * clean up / remove comments * check style (prettier) * remove b from global styles * create div for mission and vision
christophertorres1
deleted the
christophertorres/hfi-17-sponsors-past-sponsors-section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Dev
Dez
Linear Task
https://linear.app/hack-for-impact-2024/issue/HFI-17/sponsors-past-sponsors-section