add schedule #10
add schedule #10
Conversation
| text-align: center; | ||
| gap: 1.5rem; | ||
| h4 { | ||
| color: #3d3833; |
There was a problem hiding this comment.
Text elements should be using the correct color by default now! You can rebase off main and see the changes.
| <td class="time">8:00 - 8:30 am</td> | ||
| <td class="event">Registration + breakfast</td> | ||
| </tr> | ||
| <tr class="schedule-row"> |
There was a problem hiding this comment.
nit: i don't think this class is being used, do you think we can remove it?
| <section id="schedule"> | ||
| <div class="header-container"> | ||
| <h4>SCHEDULE</h4> | ||
| <h2>1 day, but <b>countless</b> possibilities</h2> |
There was a problem hiding this comment.
h2 here should be h3 and b should be h2. Although we don't anticipate styles to change, it's best to stay consistent with the predefined global styles so we can quickly update if things do change.
| p { | ||
| color: #3d3833; | ||
| font-weight: 500; | ||
| } |
There was a problem hiding this comment.
This p tag can be removed to use the default styles! (rebase off main to see changes)
|
|
||
| .schedule-container { | ||
| width: 58.5rem; | ||
| height: 47.25rem; |
There was a problem hiding this comment.
Please don't set a fixed value for height when you've already fixed width, this is a bad practice for containers like this - the text will not wrap, or if it does, it will overflow, leading to unintended layouts on smaller screen sizes.
Instead, I would recommend width: 100% and add horizontal padding to match the design.
| h4 { | ||
| color: #3d3833; | ||
| font-weight: 400; | ||
| letter-spacing: 0.05rem; |
There was a problem hiding this comment.
I think @ccatherinetan also defined this, make sure yall use the same letter-spacing!! It would be best to alter _global.scss and agree to one single property across all h4s.
We have the changes merged in main now! You don't have to redefine the styles here - just need to rebase off main.
| .event { | ||
| width: 35.9375rem; | ||
| color: #3d3935; | ||
| padding-left: 3rem; | ||
| } |
There was a problem hiding this comment.
I believe that, in Figma, the text in the .event column should have font-weight: 400 (regular). Do you want to double check?
| flex-shrink: 0; | ||
| border-radius: 1rem; /* Nonzero border radius with hidden */ | ||
| overflow: hidden; /* overflow got rid of table's outer border */ | ||
| border: 1px solid #dfd2c4; |
There was a problem hiding this comment.
Since we use the border color in multiple places, you may want to turn it into a Sass variable! It can be defined at the top of this style or in a separate file.
christophertorres1
deleted the
christophertorres/hfi-15-schedule-section
branch
What's new?
Linear Task
https://linear.app/hack-for-impact-2024/issue/HFI-15/schedule-section