Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aivant/offline #56

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

Aivant/offline #56

wants to merge 58 commits into from

Conversation

aivantg
Copy link
Collaborator

@aivantg aivantg commented Apr 21, 2018

I promise it works, I will write details of what happened later.

*Note, in no sense is this a pull request ONLY related to offline, a lot happened here. again, will write soon

aivantg and others added 30 commits April 11, 2018 20:15
@aivantg
Added course_teachers and sessions download to Courses screen. workin…
09e7a93 
…g on viewcourse screen
@aivantg
finished making ViewcourseScreen offline
4c23688
@aivantg
Merge branch 'aivant/attendanceUpdates' of https://github.com/calblue…
4ea4e32 
…print/dream-mobile into aivant/offline
@aivantg
View Course Screen is now offline
1ff4bc0
@aivantg
updates
00a869e
@aivantg
Merge branch 'aivant/attendanceUpdates' of https://github.com/calblue…
30d8066 
…print/dream-mobile into aivant/offline
@aivantg
Finished Student Stats....still need to deal with student dupiclate c…
fe3305a 
…opies though
@aivantg
Fixed modal index error
a784bc1
@aivantg
No longer logs in twice
a83d8d9
@aivantg
fixed attendance modal, student stats, and attendance unsynced on cou…
73802dc 
…rse card
@aivantg
Changed a reducer to include locale and added localization on Teacher…
cd839ac 
…Profile and LoginScreen
@aivantg
I18nized courses screen and removed loginscreen junk
ec3213b
@aivantg
Merged with localization
0683214
@aivantg
fixed coursesscreen small bug
8eba0a8
@aivantg
Merged + Finished localization
aef2584
@aivantg
doing stuffs
ae93aa8
@aivantg
Switched to Expo Fork of React Native and now sync local changes when…
7656791 
…ver you go online
@aivantg
MErged from master and removed fake offline throws
947ba99
@aivantg
reduxified StudentProfile (but not the embedded screens
4cfc657
@aivantg
Internationalized ViewCourseScreen
e121fa5
Merge branch 'master' of https://github.com/calblueprint/dream-mobile …
e239338 
…into aivant/offline
styled student profile midway
34932ef
@JustinMi
Merge branch 'master' of https://github.com/calblueprint/dream-mobile …
fc94741 
…into aivant/offline
@aivantg
Fixed student mapping bug temporarily
d594ecc
@aivantg
fixed course editing bug
11598e6
@aivantg
switched settings back to localhost
d3b145f
@JustinMi
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
7c66921 
…m-mobile into aivant/offline
empty state for courses
31938de
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
54bb0d9 
…m-mobile into vanessa/student_styling
@aivantg
added [email protected] alias
32ed4fe
JustinMi and others added 16 commits April 21, 2018 19:47
@JustinMi
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
4ffeb1e 
…m-mobile into aivant/offline
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
92be205 
…m-mobile into aivant/offline
fixed course card padding
050ce11
styled student profile
b348863
removed edit from attendance summary screen
389a25d
Merge branch 'vanessa/student_styling' of https://github.com/calbluep…
50b26ec 
…rint/dream-mobile into aivant/offline
made navbar of edit course neutral
13c32cb
navigate error on edit student proflie fixed but rails error
4e949b5
removed refresh students function
06ca3a6
courseId lol
1351325
@aivantg
Fixed Enroll Student Screen
a38434f
@aivantg
Disabled gestures on courses screen so you can't swipe back to log out
8d08ab8
@JustinMi
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
9fa8dbf 
…m-mobile into aivant/offline
@JustinMi
made the courses screen background entirely white
940745a
@aivantg
Added alt url and faked attendance item post
b4ada1c
@aivantg
Merge branch 'aivant/offline' of https://github.com/calblueprint/drea…
bcbfbc0 
…m-mobile into aivant/offline
@vanesng
Copy link
Collaborator

vanesng commented May 6, 2018 •
edited
Loading

@aivantg
Some bugs (will edit this list as I notice more)!

Bug 1

  • This flow seems to yield duplicated list of students in attendances:
    1. Courses screen > Take attendance > Sync
    2. Click into course you just took attendance for > View Past Attendances
    3. Go to current date's > Somehow double the number of students present just for current date's attendance.

Bug 2

  • If I enroll a new student after attendance has been taken for today, there is no way for the new student to appear on today's attendance. As such, unable to log newly enrolled student's attendance if you already have taken attendance for the day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aivantg @vanesng @JustinMi