completed the house form for creating and updating houses #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Created the house form component with creating and updating functionality
When updating, the houseId must be passed into the component to select the correct house
If there is no houseId passed in, firebase will create a new document with the given name, houseId, and address parameters
Screenshots
N/A
How to review
Try to add and update different houses
Form validation
Next steps
For some reason, there is a slight delay now when updating an existing house; the parameters don't load in on the first click, but are there every time after. I don't know why yet because it was previously working as expected. I will get back around to this soon so don't merge yet.
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa