Marcos/user forms #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Created form to add/create new user from the manager's account.
Screenshots
<img width="957" alt="Screenshot 2023-03-17 at 1 29 02 PM" src="https://user-images.githubusercontent.com/123115186/2260
32211-debe0679-2923-4421-b35e-32a1056c7e1e.png">
How to review
UserForm.tsx was the file being edited and should be reviewed all together. To test, log into a manager account. The URL should be at "http://localhost:####/manager/______". Replace the last word of the URL (blank line) with "members" to access the correct page. Then, click on the button "ADD USER" which will open the form. Continue filling out the information for a new user (whether it be a manager or member) which takes in a first name, last name, display name, email, role, and House ID. After pressing "SUBMIT", check the Firebase to verify that a new user has been created with the correct starting attributes.
Next steps
Some next steps would be top add a page/category to navigate to the "members" page for managers as it is not currently doable without editing the URL itself. Formatting is also another step to be taken in order to match the theme of the website.
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa