-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marcos/edit member infov3 #69
Open
MarcosH28
wants to merge
61
commits into
main
Choose a base branch
from
marcos/editMemberInfov3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m working on seting up the createApi slide for the project
…ntrollers. Fixed the warning message on the console regarding the nesting of the elements. fixed most of the typescript errors and wrnings for the code i wrote
…rative into greg/fixing-api-bugs
…cooperative into dev/main
…student-cooperative into dev/main
…ey-student-cooperative into dev/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Updated the User Form under the "Planner" section for manager accounts.
Description
Adding/editing users in the manager's planner now only take the first name, last name, and email to be added/edited. Once changes are submitted/saved, the appropriate table is updated.
Screenshots
How to review
Files edited: berkeley-student-cooperative/src/components/ManagerComponents/userCard/UserForm.tsx
Should be reviewed all at once since I only committed once. To access, log in as a manager and open the "Planner" section. In the second table, select "ADD USER" to create a new user or one of the users already created to edit the information. Depending on the option selected, the proper information will pop up under the "First name", "Last name", or "Email" text box to be changed. There is an option to add a new user which should not work at this point since every user that is changed/added should exist already (could be useful for a future feature).
Next steps
The HouseID should be changeable for all houses in the future (set to EUC by default).
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa