Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bus Cost Analysis Refactor 2 #1175

Merged
merged 17 commits into from
Jul 12, 2024
Merged

Bus Cost Analysis Refactor 2 #1175

merged 17 commits into from
Jul 12, 2024

Conversation

csuyat-dot
Copy link
Contributor

Received feedback on first version of cost_per_bus_analysis.pdf and incorporated into this iteration. Details include:

  • Testing converting the notebook to PDF using; nbconvert, LaTex commands, papermill and weasyprint. Settled on converting NB to HTML then to PDF using nbconvert and weasyprint to preserve the font, charts and table styles.
  • renamed scripts and files to follow a pseudo-chronological order.
  • updated Makefile to match new file names and to execute the pdf conversion.
  • refactored outlier flag function and bus cost aggregation function to display project count and grand totals.
  • added more narrative to explain some of the charts.
  • minor edits to the intro and conclusion sections
  • add <br> HTML tags to assist with page breaks
  • manually removed blank first page on PDF and reuploaded.

csuyat-dot added 17 commits July 2, 2024 21:44
@csuyat-dot
minor updates to narrative. experimenting with exporting to pdf and html
34791cc
@csuyat-dot
testing weasyprint to export NB to pdf
b81c2bd
@csuyat-dot
still experimenting converting NB > HTML > PDF using nbconvert and we…
b43c380 
…asyprint
@csuyat-dot
final attempt at converting NB to pdf. also testing papermill and nbc…
cc43299 
…onvert webpdf but need to install other stuff
@csuyat-dot
edited and renamed weasyprint files
37c1c12
@csuyat-dot
testing LaTex page break. got page break to work with straight nbconv…
770fe50 
…ert, but not with weasyprint
@csuyat-dot
tested papermill and LaTex but ended up using weasyprint and <br> tag…
07ab332 
…s to get my pseudo-page breaks
@csuyat-dot
renamed files in pseudo-chronilogical order, updated Makefile
4686e2c
@csuyat-dot
renamed files again to a working syntax. updated makefile, ran makefi…
17822c5 
…le and everything is running as intended
@csuyat-dot
tested refactored outlier flag function. added updated func to affect…
c456f70 
…ed scripts. left notes in the refactor NB
@csuyat-dot
fixed keyerror. ran Makefile and everything is running well
eb1b777
@csuyat-dot
added new column for # of projects to pivot_source table
824a757
@csuyat-dot
created a new agg function that also returns the count of projects an…
781d04f 
…d grand totals. updated the NB with the new func and re-ran aggregations, charts and tables
@csuyat-dot
more changes to NB from feedback
c97266d
@csuyat-dot
final addtions and edits: appendix, removed dupe tables, expanded int…
26a0b82 
…ro and conclusion
@csuyat-dot
fixed the spacing of the final NB, Makefile is running/producing the …
7e90fa8 
…pdf as intended
@csuyat-dot
updated readme, ran make file, deleted blank front page of pdf, delet…
101d8a5 
…ed test latex, papermill, weasyprint files
@github-actions GitHub Actions
Copy link

nbviewer URLs for impacted notebooks:

@csuyat-dot csuyat-dot marked this pull request as ready for review July 12, 2024 20:47
@csuyat-dot csuyat-dot merged commit d33a9b3 into main Jul 12, 2024
3 checks passed
@csuyat-dot csuyat-dot deleted the bus_cost_feedback_add branch July 12, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@csuyat-dot