WIP: refactor(*): return FileHeader in the File method #436
Conversation
caicloud-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -252,7 +252,7 @@ func (g *FileParameterGenerator) Validate(name string, defaultValue interface{}, | |||
| // Generate generates an object by data from value container. | |||
| func (g *FileParameterGenerator) Generate(ctx context.Context, vc ValueContainer, consumers []Consumer, | |||
| name string, target reflect.Type) (interface{}, error) { | |||
| file, ok := vc.File(name) | |||
| file, _, ok := vc.File(name) | |||
There was a problem hiding this comment.
你想从业务函数那里直接拿到吗，那里是拿不到的，那儿只有一个位置，也不可能对应两个参数
service.HTTPContextFrom(ctx) 转换 context 可以取到这个值
There was a problem hiding this comment.
那是不是返回 FileHeader 更好，因为 File 可以通过 FileHeader.Open() 拿到
iawia002
changed the title
caicloud-bot
added
the
do-not-merge/work-in-progress
What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @whalecold
Release note: