Deprecate gometalinter and use golangcli-lint instead (kubeflow#56)

*  Deprecate gometalinter and use golangcli-lint for lint

https://github.com/alecthomas/gometalinter has been deprecated and author suggest to use https://github.com/golangci/golangci-lint instead.

Migrate most of the linters to golangci-lint.

Remove original linter_config.json and add linter_config.yaml

Signed-off-by: Jiaxin Shan <[email protected]>

* Fix Error return value of not checked problems in tests

errcheck will report issue if return value is not used. One example is

pkg/controller.v1beta1/mxnet/pod_test.go:66:10: Error return value of `ctr.Run` is not checked (errcheck)
		ctr.Run(testutil.ThreadCount, stopCh)
		       ^

Signed-off-by: Jiaxin Shan <[email protected]>

* Update-codegen to update copyright header

Signed-off-by: Jiaxin Shan <[email protected]>

.travis.yml

@@ -8,14 +8,14 @@ go_import_path: github.com/kubeflow/mxnet-operator
 install:
   # get coveralls.io support
   - go get github.com/mattn/goveralls
-  - go get -u github.com/alecthomas/gometalinter
-  - gometalinter --install
+  # Install golangci-lint
+  - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.7
 
 script:
   - hack/verify-codegen.sh
   - go build -o mxnet-operator.v1beta1 github.com/kubeflow/mxnet-operator/cmd/mxnet-operator.v1beta1
   - go build -o mxnet-operator.v1 github.com/kubeflow/mxnet-operator/cmd/mxnet-operator.v1
-  - gometalinter --config=linter_config.json --vendor ./...
+  - golangci-lint run --config=linter_config.yaml ./...
   # We customize the build step because by default
   # Travis runs go test -v ./... which will include the vendor
   # directory.

linter_config.yaml

@@ -0,0 +1,50 @@
+# This file contains golangci-lint configurations
+
+run:
+  # default concurrency is a available CPU number
+  concurrency: 4
+
+  # timeout for analysis, e.g. 30s, 5m, default is 1m
+  timeout: 300s
+
+  # exit code when at least one issue was found, default is 1
+  issues-exit-code: 1
+
+  # include test files or not, default is true
+  tests: true
+
+  # which dirs to skip: issues from them won't be reported;
+#  skip-dirs:
+#    - pkg/client
+#    - pkg/apis/mxnet/v1beta1/zz_generated.deepcopy.go
+#    - pkg/apis/mxnet/v1beta1/zz_generated.defaults.go
+
+  # default is true. Enables skipping of directories:
+  #   vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
+  skip-dirs-use-default: true
+
+linters:
+  # please, do not use `enable-all`: it's deprecated and will be removed soon.
+  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
+  disable-all: true
+  enable:
+    - bodyclose
+    - deadcode
+    - errcheck
+    - misspell
+    - lll
+    - typecheck
+    - unconvert
+    - unused
+    - varcheck
+    - govet
+    - staticcheck
+linters-settings:
+  lll:
+    # max line length, lines longer will be reported. Default is 120.
+    line-length: 240
+
+#
+#  "redundant return statement",
+#  "comment or be unexported",
+#  "comment on exported",

pkg/controller.v1/mxnet/job_test.go

@@ -66,7 +66,9 @@ func TestAddMXJob(t *testing.T) {
 
 	stopCh := make(chan struct{})
 	run := func(<-chan struct{}) {
-		ctr.Run(testutil.ThreadCount, stopCh)
+		if err := ctr.Run(testutil.ThreadCount, stopCh); err != nil {
+			t.Errorf("Failed to run MXNet Controller!")
+		}
 	}
 	go run(stopCh)
 
@@ -135,7 +137,9 @@ func TestCopyLabelsAndAnnotation(t *testing.T) {
 
 	stopCh := make(chan struct{})
 	run := func(<-chan struct{}) {
-		ctr.Run(testutil.ThreadCount, stopCh)
+		if err := ctr.Run(testutil.ThreadCount, stopCh); err != nil {
+			t.Errorf("Failed to run MXNet Controller!")
+		}
 	}
 	go run(stopCh)
 

pkg/controller.v1/mxnet/pod_test.go

@@ -63,7 +63,9 @@ func TestAddPod(t *testing.T) {
 
 	stopCh := make(chan struct{})
 	run := func(<-chan struct{}) {
-		ctr.Run(testutil.ThreadCount, stopCh)
+		if err := ctr.Run(testutil.ThreadCount, stopCh); err != nil {
+			t.Errorf("Failed to run MXNet Controller!")
+		}
 	}
 	go run(stopCh)
 
@@ -187,7 +189,9 @@ func TestExitCode(t *testing.T) {
 
 	stopCh := make(chan struct{})
 	run := func(<-chan struct{}) {
-		ctr.Run(testutil.ThreadCount, stopCh)
+		if err := ctr.Run(testutil.ThreadCount, stopCh); err != nil {
+			t.Errorf("Failed to run MXNet Controller!")
+		}
 	}
 	go run(stopCh)
 

pkg/controller.v1/mxnet/service_test.go

@@ -63,7 +63,9 @@ func TestAddService(t *testing.T) {
 
 	stopCh := make(chan struct{})
 	run := func(<-chan struct{}) {
-		ctr.Run(testutil.ThreadCount, stopCh)
+		if err := ctr.Run(testutil.ThreadCount, stopCh); err != nil {
+			t.Errorf("Failed to run MXNet Controller!")
+		}
 	}
 	go run(stopCh)