Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split static-analysis and runtime-compat jobs #10

Merged
merged 5 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,13 @@ on:
- synchronize

jobs:
ci:
static-analysis:
strategy:
matrix:
os:
- ubuntu-latest
node-version:
- 18.x
- 20.x
include:
- os: windows-latest
node-version: 20.x

runs-on: ${{ matrix.os }}

Expand All @@ -47,8 +43,6 @@ jobs:
cache: "pnpm"
- name: Install dependencies
run: pnpm install --ignore-scripts
- name: Build
run: pnpm build
- name: Lint types
run: pnpm lint:types
if: always()
Expand All @@ -61,6 +55,46 @@ jobs:
- name: Lint commits
run: pnpm lint:commits
if: always()

runtime-compat:
strategy:
matrix:
os:
- ubuntu-latest
node-version:
- 18.x
- 20.x
include:
- os: windows-latest
node-version: 20.x
- os: macos-latest
node-version: 20.x

runs-on: ${{ matrix.os }}

steps:
- name: Checkout to ${{ github.ref }}
uses: actions/checkout@v4
- name: Setup turbo cache
uses: actions/cache@v3
with:
path: node_modules/.cache/turbo
key: ${{ matrix.os }}-node-${{ matrix.node-version }}-turbo-${{ github.sha }}
restore-keys: |
${{ matrix.os }}-node-${{ matrix.node-version }}-turbo-
- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: ^8.6.2
- name: Install node ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: "pnpm"
- name: Install dependencies
run: pnpm install --ignore-scripts
- name: Build
run: pnpm build
- name: Unit test
run: pnpm test:unit
if: always()
6 changes: 3 additions & 3 deletions apps/sample-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"@pnpm-monorepo/sample-lib": "workspace:*"
},
"devDependencies": {
"eslint": "^8.52.0",
"concurrently": "^8.2.2",
"prettier": "^3.0.3",
"eslint": "^8.55.0",
"prettier": "^3.1.0",
"rimraf": "^5.0.5",
"typescript": "^5.2.2"
"typescript": "^5.3.3"
}
}
6 changes: 3 additions & 3 deletions libs/sample-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"test:unit": "echo \"Warning: no test specified\" && exit 0"
},
"devDependencies": {
"eslint": "^8.52.0",
"concurrently": "^8.2.2",
"prettier": "^3.0.3",
"eslint": "^8.55.0",
"prettier": "^3.1.0",
"rimraf": "^5.0.5",
"typescript": "^5.2.2"
"typescript": "^5.3.3"
}
}
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,22 +36,22 @@
"test:unit": "turbo run test:unit --continue"
},
"devDependencies": {
"@commitlint/cli": "^18.2.0",
"@commitlint/config-conventional": "^18.1.0",
"@commitlint/cz-commitlint": "^18.2.0",
"@typescript-eslint/eslint-plugin": "^6.9.0",
"@commitlint/cli": "^18.4.3",
"@commitlint/config-conventional": "^18.4.3",
"@commitlint/cz-commitlint": "^18.4.3",
"@typescript-eslint/eslint-plugin": "^6.13.2",
"commitizen": "^4.3.0",
"concurrently": "^8.2.2",
"eslint": "^8.52.0",
"eslint-config-prettier": "^9.0.0",
"eslint": "^8.55.0",
"eslint-config-prettier": "^9.1.0",
"eslint-import-resolver-typescript": "^3.6.1",
"eslint-plugin-import": "^2.29.0",
"eslint-plugin-perfectionist": "^2.2.0",
"eslint-plugin-perfectionist": "^2.5.0",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-unused-imports": "^3.0.0",
"only-allow": "^1.2.1",
"prettier": "^3.0.3",
"turbo": "^1.10.16"
"prettier": "^3.1.0",
"turbo": "^1.11.0"
}
}
Loading