Add subdirectory meta #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt-allen
approved these changes
Oct 30, 2023
This was referenced Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more work on the template to ensure that we can apply updates from here to downstream projects (i.e., the projects that were rendered from this). It makes sure that the
{{project_name}}directory is the proper root upon applying updates. Without this it was annoyingly re-rendering the template into a sub-directory, rather than applying updates in place.An alternative approach would be to unnest the directory structure here (everything in
{{project_name}}goes to the root), but then we'd have to deal with conflicts in, e.g., the.github/directories. So I view this as the less annoying fix.