Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI in generated projects #19

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

ian-r-rose
Copy link
Member

This side-ports a few fixes that we've made in downstream projects. Fixes #16, fixes #15

  • Use production target for docs build, dev for CI builds. This gets more correct schema names in the docs, since we have different logic for production vs dev.
  • Use "system" language for local pre-commit hooks, which is more correct and avoids creating a nonsense virtualenv.

language for local pre-commit hooks, which is more correct and avoids
creating a nonsense virtualenv.
@ian-r-rose ian-r-rose self-assigned this Oct 13, 2023
@ian-r-rose ian-r-rose force-pushed the use-prd-target-for-docs branch from 6302767 to 407915a Compare October 13, 2023 17:38
@ian-r-rose ian-r-rose marked this pull request as ready for review October 13, 2023 17:41
Copy link
Contributor

@britt-allen britt-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, thank you Ian!

@britt-allen britt-allen merged commit be80489 into main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct "system" pre-commit hooks Build dbt docs using production target
2 participants