Ftms wheel diamater for gears #2715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0f14944.
alexbee732
reviewed
Nov 1, 2024
| void ftmsbike::setWheelDiameter(double diameter) { | ||
| uint8_t write[] = {FTMS_SET_WHEEL_CIRCUMFERENCE, 0x00, 0x00}; | ||
|
|
||
| diameter = diameter * 10.0; |
There was a problem hiding this comment.
Why setting circumference as diameter*10, no mistake here?
|
No, it's the specification
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno ven 1 nov 2024 alle 02:10 Alexey Babenko ***@***.***>
ha scritto:
… ***@***.**** commented on this pull request.
------------------------------
In src/devices/ftmsbike/ftmsbike.cpp
<#2715 (comment)>
:
> @@ -170,6 +172,18 @@ void ftmsbike::zwiftPlayInit() {
}
}
+void ftmsbike::setWheelDiameter(double diameter) {
+ uint8_t write[] = {FTMS_SET_WHEEL_CIRCUMFERENCE, 0x00, 0x00};
+
+ diameter = diameter * 10.0;
Why setting circumference as diameter*10, no mistake here?
—
Reply to this email directly, view it on GitHub
<#2715 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWH3JK2V7B346CXRM7DZ6LIGPAVCNFSM6AAAAABQ4KCDXOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBZGMZDANBYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.