Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Ant and implement FE-C #1937

Closed
wants to merge 11 commits into from
Closed

Tidy up Ant and implement FE-C #1937

wants to merge 11 commits into from

Conversation

stewpend0us
Copy link

Seems like a lot of duplication across the ant classes. figured I'd start by cleaning that up first? not sure if the new file will even be built yet because it's not referenced? but wanted to see what happens.

#1930

@stewpend0us stewpend0us changed the title move some of the copy pasted code into a class Tidy up Ant and implement FE-C Jan 2, 2024
@cagnulein
Copy link
Owner

sure give it a try! when i started the ant+ implementation i felt like an elephant in a glass store :)

@cagnulein
Copy link
Owner

i approved the ci, its building now

@stewpend0us
Copy link
Author

stewpend0us commented Jan 2, 2024 •
edited
Loading

Seems like it builds at least.... Any tips on how to test?

@cagnulein
Copy link
Owner

cagnulein commented Jan 2, 2024 via email

@stewpend0us
Copy link
Author

Ohh I saw the other platforms building. Is the Ant stuff only included on Android?

@cagnulein
Copy link
Owner

Ohh I saw the other platforms building. Is the Ant stuff only included on Android?

yes :)

@stewpend0us
Copy link
Author

Think it might have just been the extra "}" can you re-run? Is the CI stuff free? I can see if I can get setup to build locally if it's a problem

@cagnulein
Copy link
Owner

Think it might have just been the extra "}" can you re-run? Is the CI stuff free? I can see if I can get setup to build locally if it's a problem

now it should approved forever. yes CI for now is free, so no problem :) if you want you can setup it locally but it's for sure a pain in the ass :D I warned you :D

@stewpend0us
Copy link
Author

Seems to still need approval?

@cagnulein
Copy link
Owner

yes i don't know why it needs always the approval, i will investigate this today, maybe i should approve you somehow

@cagnulein cagnulein self-requested a review January 3, 2024 10:13
@cagnulein cagnulein added this to the 2.16 milestone Jan 3, 2024
@cagnulein cagnulein self-assigned this Jan 3, 2024
@stewpend0us
Copy link
Author

I think I need to just get set up locally. Too embarrassing to be committing all my stupid mistakes!

@cagnulein
Copy link
Owner

hahah no problem at all! i'm doing the same when i'm doing modification on my phone :)

@stewpend0us
Copy link
Author

okkkk. I think this one might go through finally. I noticed that the frequency settings are all just slightly different across the classes is there a reason for that?

@cagnulein
Copy link
Owner

cagnulein commented Jan 4, 2024 via email

@cagnulein
Copy link
Owner

i guess the next one will be the one :) !

@stewpend0us
Copy link
Author

Lol. So painful to wait 20 minutes for a typo

@stewpend0us
Copy link
Author

NOW. Any tips on how to test this?

@cagnulein
Copy link
Owner

cagnulein commented Jan 4, 2024 via email

@stewpend0us
Copy link
Author

This seemed to work...at least as well as it did for me before. I got power (seemed right) and speed (at like 2-3x what I'd expect) same as before. Heart didn't go from watch to the app maybe my settings are wrong? obviously nothing new here just the "clean up"

@cagnulein
Copy link
Owner

Heart didn't go from watch to the app maybe my settings are wrong?

ant heart setting is enabled in qz?

@stewpend0us
Copy link
Author

Yes

@cagnulein
Copy link
Owner

i will try the build too to check if it's working on my side. i usually try with a polar hr ant+ device

@cagnulein
Copy link
Owner

cagnulein commented Jan 7, 2024 via email

@stale Stale
Copy link

stale bot commented Jan 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 23, 2024
@stale stale bot closed this Jan 30, 2024
@cagnulein cagnulein reopened this Jan 30, 2024
@stale stale bot removed the wontfix This will not be worked on label Jan 30, 2024
@stale Stale
Copy link

stale bot commented Feb 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 14, 2024
@stale stale bot closed this Feb 22, 2024
@cagnulein
Copy link
Owner

@stewpend0us Any news?

@cagnulein cagnulein reopened this Feb 22, 2024
@stale stale bot removed the wontfix This will not be worked on label Feb 22, 2024
@stewpend0us
Copy link
Author

No. :( sorry

@cagnulein
Copy link
Owner

cagnulein commented Feb 22, 2024 via email

@stale Stale
Copy link

stale bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 8, 2024
@stale stale bot closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cagnulein cagnulein Awaiting requested review from cagnulein

Assignees

@cagnulein cagnulein

Labels
android ant+ wontfix This will not be worked on
Projects
None yet
Milestone
2.16
Development

Successfully merging this pull request may close these issues.
2 participants
@stewpend0us @cagnulein