Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of the "mimetype" arg of HttpResponse with "content_type". #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

korfuri
Copy link

@korfuri korfuri commented Jun 23, 2014

mimetype has been deprecated for a long time and has been removed from
django in the development version. This commit uses content_type for
the default value but allows specifying either, regardless of the
version of Django. Specifying "mimetype" will work for users of
django-oauth2-provider if their version of django supports it (the
deprecated argument has precedence), and will break if it doesn't.

mimetype has been deprecated for a long time and has been removed from
django in the development version. This commit uses content_type for
the default value but allows specifying either, regardless of the
version of Django. Specifying "mimetype" will work for users of
django-oauth2-provider if their version of django supports it (the
deprecated argument has precedence), and will break if it doesn't.
@jarcoal
Copy link

jarcoal commented Jun 29, 2014

+1

@gio82
Copy link

gio82 commented Jul 1, 2014

+1

@pkozela
Copy link

pkozela commented Jul 4, 2014

+1

@korfuri
Copy link
Author

korfuri commented Jul 24, 2014

@eculver can you comment on this? Thanks!

@psychok7
Copy link

psychok7 commented Sep 5, 2014

+1 , i need this to work with Django 1.7

@RogerThomas
Copy link

+1 Any chance this can be merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants