to_dict() did not pass key on recursion for sort #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the @key parameter to the self.to_dict so that child nodes are also sorted by the key
anthonyrocom
commented
Apr 7, 2020
There was a problem hiding this comment.
Hi, this parameter which is still missing from this recursive function is still not available in the latest code. Can you approve the changes? It seems the Travis unit tests failed due to some archive that couldn't be downloaded, not that the code improvement failed.
liamlundy
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the @key parameter to the self.to_dict so that child nodes are also sorted by the key