Fix bug where floats were saved as strings #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When values in the PropertyEditor were changed by typing in new values, new values were saved as strings, which caused a crash when opening the saved file. This commit casts values of keys that should be floats to floats. Looked into UI-side validation (since right now the editor allows non-floats to be entered as a value) without much success; it seems that a change in PropertyEditorWidget.py (and associated classes) would need to be made. Fixes cadnano#112
|
This PR introduces a bug in line 1278 where it refers to Do you want a separate PR for changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When values in the PropertyEditor were changed by typing in new values, new values were saved as strings, which caused a crash when opening the saved file.
This commit casts values of keys that should be floats to floats. Looked into UI-side validation (since right now the editor allows non-floats to be entered as a value) without much success; it seems that a change in
PropertyEditorWidget.py(and associated classes) would need to be made.Fixes #112