Adapt interface to match CADET-Core #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some options are not available in v2 * Clarify input of hankel/laplace summands
Defaulting surface diffusion to 0.0 is consistent with the CADET-Core interface
Explicit error to prevent misuse of files that, e.g., were setup for CADET-Core
Zenodo meta data is pulled from the zenodo.json and the publication on cadet-semi-analytic is integrated by github via the CITATION.bib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the interface to match CADET-Core, namely by using 0.0 surface diffusion per default and by adding an exception for multi component systems to ease the interchangable use of cadet files.
Further, some maintenance and documentation issues are fixed.