Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h5 as output format #14

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add h5 as output format #14

merged 2 commits into from
Nov 25, 2024

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Nov 23, 2024

This PR enables h5 as output format. This is optional and comes with the loss of arbitrary precision output.
The h5 format is useful for our evalution pipelines and is used as the standard cadet simulation output. Also, arbitrary precision is rarely needed.

TODO

  • enable h5 output (results and meta) while confirming to the CADET(-Core) file format
  • outsource the h5 writeResult code to another function
  • Make the specification of output file optional when the input file is an h5 and just write solution to that file (reuse the above function)
  • update documentation including a warning about the loss of precision
  • 2D data with split ports

Fixes #8

@jbreue16 jbreue16 added this to the v2.0.0 milestone Nov 23, 2024
jbreue16 added a commit that referenced this pull request Nov 24, 2024
This commit adds the option to use h5 as output format. Note that
arbitrary precision is not supported by this (optional) output.
jbreue16 added a commit that referenced this pull request Nov 25, 2024
This commit adds the option to use h5 as output format. Note that
arbitrary precision is not supported by this (optional) output.
This commit adds the option to use h5 as output format. Note that
arbitrary precision is not supported by this (optional) output.
@jbreue16 jbreue16 merged commit 25ef992 into master Nov 25, 2024
1 check passed
@jbreue16 jbreue16 deleted the feature/h5Output branch November 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable writing of solution to input h5 file
1 participant