Fix parallelization test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `cadet_path` is not reset, there are undesired consequences which affect other tests.
This test is obsolte; functionatlity is now tested in test_install_path_settings.py
Because the DLL lives in different subdirectories in Windows / Posix, we should test their parent to ensure the test runs independent of the OS.
Else, there could be errors when deleting the object.
schmoelder
force-pushed
the
fix_parallelization_test
branch
from
0ff3a1f to
b3f6185
Compare
|
All tests working on Linux and Windows with Core v.5.0.2 👍 |
|
I forgot again, but we can delete this one, right? 🙈 |
|
No, this is our work from this morning fixing the CadetMeta class, we want to merge this into master and release with v1.0.2! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
However, there are surely multiple solutions to this issue!