Do not modify LD_LIBRARY_PATH when setting install_path #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was required to add <root>/lib to LD_LIBRARY_PATH because CADET-Core was not setting the RPATH correctly. This was fixed in CADET v4.4.0 Since the lib path was simply appended to os.environ['LD_LIBRARY_PATH'] this could lead to inconsistent behaviour when trying to compare different versions of CADET-Core and other versions were not properly removed.
ronald-jaepel
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was required to add
<root>/libtoLD_LIBRARY_PATHbecause CADET-Core was not setting the RPATH correctly. This was fixed in CADET v4.4.0Since the lib path was simply appended to
os.environ['LD_LIBRARY_PATH']this could lead to inconsistent behaviour when trying to compare different versions of CADET-Core and other versions were not properly removed.