first implementation of easy def model #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added residual and testfiles Removed false risidual, + cstr residual v<0 => error Seperated error testing in another class Throw not implemented error @Viscosity Notinitialized Error now inherits from CADETPython SimulatorError
happening adding a pipeline.yml for testing with pytest on push adding ruff.yml wip addded a ruff workflow added python 3.12 to the pipeline to check when sundials and numpy are working
Add dead end filtration
residuals + unit operation still need testing
Not all tests where found, now all are executed .... but not all finish
schmoelder
force-pushed
the
master
branch
2 times, most recently
from
112dadf to
e83f534
Compare
cadet process and fixes the small bug with the molecular weight, added molecular volume first implementation of the def unit_operation and residual equations still both still need testing and unit_operation def doesn't have rejection model yet
CAKEVOLUME and PRESSURE DROP Adjusted tests for unit_operation to the new CPSComponentsystem
Added residual and testfiles Removed false risidual, + cstr residual v<0 => error Seperated error testing in another class Throw not implemented error @Viscosity Notinitialized Error now inherits from CADETPython SimulatorError
happening adding a pipeline.yml for testing with pytest on push adding ruff.yml wip addded a ruff workflow added python 3.12 to the pipeline to check when sundials and numpy are working
Add dead end filtration
residuals + unit operation still need testing
Not all tests where found, now all are executed .... but not all finish
cadet process and fixes the small bug with the molecular weight, added molecular volume first implementation of the def unit_operation and residual equations still both still need testing and unit_operation def doesn't have rejection model yet
CAKEVOLUME and PRESSURE DROP Adjusted tests for unit_operation to the new CPSComponentsystem
…l' of https://github.com/cadet/CADET-Python-Simulator into add-model-equations-for-simple-dead-end-filtration-model
|
Hey @daklauss could you please rebase onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of the easy def model as described in #5, stil wip
TODOS: