Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment.yml encoding and improve documentation #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cbix
Copy link
Member

@cbix cbix commented Dec 9, 2024

For some reason the environment.yml is recognized as a binary file in git, which should be fixed by this patch.

  • See cd8bed0 for a diff with proper detection.

@cbix cbix self-assigned this Dec 9, 2024
@cbix cbix requested a review from daklauss December 9, 2024 11:01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary file not shown.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That just means github doesn't attempt displaying it. The PR diff still says BIN but for the last commit cd8bed0 you'll see it treated as a text file. I could explicitly add it to .gitattributes but IMO that's not necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have been there earlier. Thanks

@cbix cbix requested a review from daklauss December 9, 2024 13:08
@cbix cbix changed the title Fix environment.yml encoding Fix environment.yml encoding and improve documentation Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants