-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add field #19
base: master
Are you sure you want to change the base?
[WIP] Add field #19
Conversation
Seperated the tests of the field file into a seperate test_field.py file. Stillt need some rework but it should be more structured. |
@cbix Call me pedantic but I loathe merge commits. Are you ok with rebasing? 😅 Btw, do you know lazygit? |
@schmoelder Sure, whatever is preference in the project :) In general I'd use merge commits especially on shared branches, because the collaborators can simply pull to update, rebasing and force-push makes collaboration a bit tricky. Then squash-merging PRs but I understand that people would want to keep individual commits in history instead of squashing. |
That's certainly true. Then I'd say, do whatever you want in your PR during "draft phase" but clean up before review / merging, ok? |
This PR adds an new
Field
class which enhances current capabilities of theState
.Eventually, we need to reconsider how we integrate it into the existing framework.
For now, we use this PR to coordinate the development of external functions which will use the same structures (in Python).
Play around
Familiarize yourselves with the module:
Improve testing
Implement use cases
(can be done outside of this repo)
Missing features
pchip
is hard coded)