-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binding model submodule tests to CI #360
base: master
Are you sure you want to change the base?
Conversation
2e2cfad
to
08785e0
Compare
Fix FD pattern sign tolerance in Fruendlich LDF test In the test settings, remove EXT_ prefix from constant binding parameters, fixing the configuration of external binding parameter handler
08785e0
to
d5428be
Compare
I'm torn on adding the |
Thought the exact same thing but then didnt see an easy way to parameterize that. |
I like it. Thanks for the quick change! I also think it's fine to include all binding tests by default, because they are super quick. LGTM now. Once the tests have passed again you or I can squash and merge. |
wait, this is the same error cause we had in #273 Ill look into it |
Could be. Thanks for looking into it! Let me know if you want to debug together. |
This PR adds all binding model submodule tests to the CI, e.g. Jacobian tests for the bindings, without other modules like the unit operation.
fixes #356
TODO