Refactor timer gate and fix goroutine leak problem #6630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
common/clock
packagetime.Timer
typeClose
method and IntroduceStop
method which has a different behavior:Stop
method behaves like theStop
method oftime.Timer
. It just clears the existing timer if any. A new timer can be reset viaUpdate
method.Why?
Code refactoring and bug fixes
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes