Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for accessing public config #796

Merged
merged 3 commits into from
Jan 21, 2025
Merged

API for accessing public config #796

merged 3 commits into from
Jan 21, 2025

Conversation

Assem-Hafez
Copy link
Contributor

Summary

Creating API to access configurations flagged as public from client side.

Changes

  • Create a route & route handler for getConfig
  • Validate route inputs (key & args) based on config definition
  • Create a mock for get-config-value utility
  • Add types for public config and refactor resolved value types

adhityamamallan
adhityamamallan approved these changes Jan 21, 2025
View reviewed changes
src/app/api/config/route.ts

import getConfig from '@/route-handlers/get-config/get-config';

export async function GET(request: NextRequest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some auth here so that not everyone can request configs

@Assem-Uber Assem-Uber merged commit 9fc9459 into cadence-workflow:release/4.0.0 Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhityamamallan adhityamamallan adhityamamallan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Assem-Hafez @adhityamamallan @Assem-Uber