remove closeModal

cadence-workflow · Jan 15, 2025 · 7474cda · 7474cda
1 parent d15f684
commit 7474cda
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/src/views/workflow-actions/__fixtures__/workflow-actions-config.ts b/src/views/workflow-actions/__fixtures__/workflow-actions-config.ts
@@ -11,7 +11,6 @@ export const mockWorkflowActionsConfig = [
     getIsEnabled: () => true,
     apiRoute: 'cancel',
     onSuccess: (params) => {
-      params.onCloseModal();
       params.sendNotification('Mock notification');
     },
   },
@@ -23,7 +22,6 @@ export const mockWorkflowActionsConfig = [
     getIsEnabled: () => false,
     apiRoute: 'terminate',
     onSuccess: (params) => {
-      params.onCloseModal();
       params.sendNotification('Mock notification');
     },
   },

diff --git a/src/views/workflow-actions/config/workflow-actions.config.ts b/src/views/workflow-actions/config/workflow-actions.config.ts
@@ -20,8 +20,7 @@ const workflowPageActionsConfig: [
         workflow.workflowExecutionInfo?.closeEvent?.attributes ?? ''
       ),
     apiRoute: 'cancel',
-    onSuccess: ({ onCloseModal, sendNotification }) => {
-      onCloseModal();
+    onSuccess: ({ sendNotification }) => {
       sendNotification('Workflow cancellation has been requested.');
     },
   },
@@ -35,8 +34,7 @@ const workflowPageActionsConfig: [
         workflow.workflowExecutionInfo?.closeEvent?.attributes ?? ''
       ),
     apiRoute: 'terminate',
-    onSuccess: ({ onCloseModal, sendNotification }) => {
-      onCloseModal();
+    onSuccess: ({ sendNotification }) => {
       sendNotification('Workflow has been terminated.');
     },
   },

diff --git a/src/views/workflow-actions/workflow-actions-modal-content/workflow-actions-modal-content.tsx b/src/views/workflow-actions/workflow-actions-modal-content/workflow-actions-modal-content.tsx
@@ -87,10 +87,11 @@ export default function WorkflowActionsModalContent<R>({
                   queryKey: ['describe_workflow', workflowDetailsParams],
                 });
 
+                onCloseModal();
+
                 action.onSuccess({
                   result,
                   inputParams: params,
-                  onCloseModal,
                   sendNotification: (message, duration) =>
                     enqueue(
                       {

diff --git a/src/views/workflow-actions/workflow-actions.types.ts b/src/views/workflow-actions/workflow-actions.types.ts
@@ -15,7 +15,6 @@ export type WorkflowActionOnSuccessParams<R> = {
   result: R;
   inputParams: WorkflowActionInputParams;
   sendNotification: (message: React.ReactNode, duration?: Duration) => void;
-  onCloseModal: () => void;
 };
 
 export type WorkflowAction<R> = {