Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode: write status immediate for success response for CONNECT requests #6738

Merged
merged 5 commits into from
Dec 11, 2024
Merged

encode: write status immediate for success response for CONNECT requests #6738

merged 5 commits into from
Dec 11, 2024
+27 −5

Conversation

WeidiDeng
Copy link
Member

fix 6733.

@WeidiDeng WeidiDeng requested a review from mholt December 8, 2024 12:52
@WeidiDeng
treat first write and flush for encode response writer to CONNECT req…
c928096 
…uest as success if status is not set explicitly
@JeDaYoshi JeDaYoshi mentioned this pull request Dec 11, 2024
Merged
mholt
mholt approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Weidi, thank you for going down the rabbit hole on this one.

@mholt mholt merged commit bcaa8aa into master Dec 11, 2024
33 checks passed
@mholt mholt deleted the encode-connect branch December 11, 2024 18:15
@mholt mholt added the bug 🐞 Something isn't working label Dec 11, 2024
@mholt mholt added this to the v2.9.0-beta.4 milestone Dec 11, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bt90 bt90 bt90 left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.9.0-beta.4
Development

Successfully merging this pull request may close these issues.

reverse_proxy: h2 websocket stuck if client needs to send the first message and encode is enabled
3 participants
@WeidiDeng @mholt @bt90