Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse_proxy: handle buffered data during hijack #6274

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

WeidiDeng
Copy link
Member

Fix 6273.

The cause of the problem can be found in the comment.

@WeidiDeng WeidiDeng marked this pull request as ready for review April 26, 2024 01:01
@mholt
Copy link
Member

mholt commented Apr 26, 2024

Awesome, that was fast. Thank you! Will await @pando-emil to verify that it is fixed.

@mholt mholt added this to the v2.8.0 milestone Apr 26, 2024
@mholt mholt added the bug 🐞 Something isn't working label Apr 26, 2024
pando-emil added a commit to pando-emil/caddy that referenced this pull request Apr 26, 2024
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work Weidi.

@mholt mholt merged commit 1b9042b into master Apr 26, 2024
23 checks passed
@mholt mholt deleted the hijack-buffer-fix branch April 26, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing byte in first websocket message
2 participants