pass params
as a dict into policy and state update functions
#303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my code, system parameters are passed (as
params
) into policy and state update functions as a list with a single dictionary item. For example,params
might look like:This feels unintuitive, and necessitates something like
params, = params
(shorthand forparams = params[0]
) at the top of each function.Separately, this issue was discussed here.
This PR may fixes this issue for me, in
EXEC_MODE.single_proc
mode, version0.4.28
.Before considering a merge, a discussion should be had about whether this is expected to work across the gamut of execution modes.