(GAP-1984) Adds Navbar for authenticated users #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicwest
reviewed
Nov 7, 2023
Comment on lines
24
to
26
| jest.mock('next/config', () => () => ({ | ||
| publicRuntimeConfig: {}, | ||
| })); |
There was a problem hiding this comment.
If this is repeated a lot, can setup jest to run it before each test using some config
pages/api/logout/index.ts
Outdated
| `session_id=deleted; Path=/; secure; HttpOnly; SameSite=Strict; expires=Thu, 01 Jan 2003 00:00:00 GMT`, | ||
| ); | ||
| const logoutUrl = | ||
| process.env.ONE_LOGIN_ENABLED === 'true' |
There was a problem hiding this comment.
I'm not sure there is a scenario where the user can logout if One Login is disabled. In that case we shouldn't display the logout link
john-tco
force-pushed
the
feature/GAP-1984-auth-nav
branch
from
e04be25 to
c44534d
Compare
dylanwrightCO
previously approved these changes
Nov 8, 2023
jgunnCO
reviewed
Nov 8, 2023
| | (NextIncomingMessage & { cookies: NextApiRequestCookies }) | ||
| | NextApiRequest, | ||
| ) => { | ||
| if (!process.env.SESSION_COOKIE_NAME) { |
There was a problem hiding this comment.
should add SESSION_COOKIE_NAME to .env.example
jgunnCO
reviewed
Nov 8, 2023
| 'Set-Cookie', | ||
| `session_id=deleted; Path=/; secure; HttpOnly; SameSite=Strict; expires=Thu, 01 Jan 2003 00:00:00 GMT`, | ||
| ); | ||
| res.redirect(302, process.env.V2_LOGOUT_URL); |
There was a problem hiding this comment.
need to add this to .env.example as well
jgunnCO
reviewed
Nov 8, 2023
|
|
||
| const logoutAdmin = async (sessionCookie: string) => | ||
| axios.delete( | ||
| `${process.env.ADMIN_BACKEND_HOST}/logout`, |
There was a problem hiding this comment.
also needs to go in .env.example
jgunnCO
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GAP-1984
todo - drill the
isUserLoggedInprop into every single page OR remove Layout from every single page and renderLayoutfrom app entrypointui
Type of change
Please check the relevant options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes:
Unit Test
Integration Test (if applicable)
End to End Test (if applicable)
Screenshots (if appropriate):
Please attach screenshots of the change if it is a UI change:
Checklist: