Fixing uploading accessibility report format (#197)

* Fixing uploading accessibility report format * Replace all illegal chars in filename
cabinetoffice · Apr 29, 2024 · 52b0226 · 52b0226
1 parent e468231
commit 52b0226
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/reusable_e2e_test_run.yml b/.github/workflows/reusable_e2e_test_run.yml
@@ -178,13 +178,14 @@ jobs:
         if: ${{ !cancelled() && failure() }}
 
       - name: Set current date as env variable
-        run: echo "NOW=$(date +'%Y-%m-%dT%H:%M:%S')" >> $GITHUB_ENV
+        id: now
+        run: echo "NOW=$(date +'%Y-%m-%dT%H-%M-%S')" >> $GITHUB_ENV
         if: ${{ !cancelled() }}
 
       - name: Upload accessibility report
         uses: actions/upload-artifact@v4
         with:
-          name: accessibility-report-${{ inputs.environment }}-${{ inputs.browser }}-${{ env.NOW }}
+          name: accessibility-report-${{ inputs.environment }}-${{ inputs.browser }}-${{ steps.now.outputs.NOW }}
           path: /home/runner/work/gap-automated-tests/gap-automated-tests/cypress/accessibility/logs
           retention-days: 30
         if: ${{ !cancelled() }}
diff --git a/cypress/common/common.ts b/cypress/common/common.ts
@@ -320,7 +320,8 @@ function accessibilityLogInfo(violationData) {
     const info = formatAccessibilityViolations(violationData, url);
 
     const specName = Cypress.spec.name;
-    const testName = Cypress.currentTest.title;
+    // Replaces all illegal chars for a filename
+    const testName = Cypress.currentTest.title.replace(/[<>"=/\\]/g, '');
 
     cy.writeFile(
       `cypress/accessibility/logs/${specName}/${testName}.md`,