Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify toMap on Windows implementation #343

Closed
wants to merge 1 commit into from

Conversation

alexandear
Copy link
Contributor

The PR refactors toMap implementation. Additionally, it enables ineffassign linter that founds that p := strings.SplitN(e, "=", 2) is redundant.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1f955b7) to head (6d9c7a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #343   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          626       626           
=========================================
  Hits           626       626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alexandear alexandear closed this Nov 20, 2024
@alexandear
Copy link
Contributor Author

strings.CutPrefix is not available on Go 1.18. It was added in Go 1.20

@alexandear alexandear deleted the refactor/simplify-tomap branch November 20, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant