fix: didn't consider json.Marshaler/Unmarshal when handling json:",string" tag
#682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
===========================================
- Coverage 52.21% 39.55% -12.66%
===========================================
Files 158 83 -75
Lines 10994 7283 -3711
===========================================
- Hits 5740 2881 -2859
+ Misses 4927 4148 -779
+ Partials 327 254 -73 ☔ View full report in Codecov by Sentry. |
liuq19
approved these changes
Aug 6, 2024
MrAlias
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
Aug 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/bytedance/sonic](https://togithub.com/bytedance/sonic) | `v1.12.0` -> `v1.12.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bytedance/sonic (github.com/bytedance/sonic)</summary> ### [`v1.12.1`](https://togithub.com/bytedance/sonic/releases/tag/v1.12.1) [Compare Source](https://togithub.com/bytedance/sonic/compare/v1.12.0...v1.12.1) #### What's Changed - fix(arm): remove print debug by [@​liuq19](https://togithub.com/liuq19) in [https://github.com/bytedance/sonic/pull/681](https://togithub.com/bytedance/sonic/pull/681) - fix: remove unused code by [@​liuq19](https://togithub.com/liuq19) in [https://github.com/bytedance/sonic/pull/683](https://togithub.com/bytedance/sonic/pull/683) - feat:(ast) nill Node can marshal to `null` by [@​AsterDY](https://togithub.com/AsterDY) in [https://github.com/bytedance/sonic/pull/685](https://togithub.com/bytedance/sonic/pull/685) - fix: didn't consider `json.Marshaler/Unmarshal` when handling `json:",string"` tag by [@​AsterDY](https://togithub.com/AsterDY) in [https://github.com/bytedance/sonic/pull/682](https://togithub.com/bytedance/sonic/pull/682) **Full Changelog**: bytedance/sonic@v1.12.0...v1.12.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJTa2lwIENoYW5nZWxvZyIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.