Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to runtime package #660

Closed
stefanb opened this issue Jun 25, 2024 · 3 comments
Labels
known-issue This issue is known to us, we are working on it

Comments

@stefanb
Copy link

stefanb commented Jun 25, 2024

While testing Go 1.23 rc1 in

there was an error:

  # github.com/hdt3213/rdb
  link: github.com/bytedance/sonic/ast: invalid reference to encoding/json.safeSet

Go 1.23 no longer allows //go:linkname * runtime.* link instructioins, see

It is used several times in this module, see:
https://github.com/search?q=repo%3Abytedance%2Fsonic%20linkname&type=code

@xin-hao-2025
Copy link

got the same issue from cloudwego/hertz.

@AsterDY
Copy link
Collaborator

AsterDY commented Jun 26, 2024

We are handling this. Please wait for a while

@stefanb
Copy link
Author

stefanb commented Jun 26, 2024

Thanks, i see you have already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
known-issue This issue is known to us, we are working on it
Projects
None yet
Development

No branches or pull requests

3 participants