Fix ioctl numbers on BSDs #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notgull I don't know how these work; do these look right to you? |
|
Yeah those look right to me. I don't know how IOCTL numbers work on BSD. I copied from |
|
The C macro definitions in https://github.com/freebsd/freebsd-src/blob/master/sys/sys/ioccom.h aren't too incomprehensible. |
|
Sounds good. Could you add a comment mentioning that (a) those correspond to |
`<sys/ioccom.h>` defines `IOC_OUT` as `0x40000000UL`. But this is "out" from the perspective of the kernel, not the application. So this corresponds to `READ` rather than `WRITE`. Tested on FreeBSD with Smithay/drm-rs#180. This also seems to be correct for NetBSD and OpenBSD.
|
Thanks! |
|
This is now released in rustix 0.38.22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<sys/ioccom.h>definesIOC_OUTas0x40000000UL. But this is "out" from the perspective of the kernel, not the application. So this corresponds toREADrather thanWRITE.Tested on FreeBSD with Smithay/drm-rs#180. This also seems to be correct for NetBSD and OpenBSD.