Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ZStr and ZString. #337

Merged
merged 6 commits into from
May 27, 2022
Merged

Remove ZStr and ZString. #337

merged 6 commits into from
May 27, 2022

Conversation

sunfishcode
Copy link
Member

Use CStr and CString instead, now that nightly has then in core and
alloc, respectively.

Fixes #336.

@sunfishcode
Copy link
Member Author

This also removes the need for several scary featuress in src/lib.rs, about 58 unsafe blocks, and almost 2000 lines of code.

@sunfishcode sunfishcode force-pushed the sunfishcode/remove-zstr branch from 5116523 to 6da94be Compare May 21, 2022 20:45
@sunfishcode sunfishcode added the semver bump Issues that will require a semver-incompatible fix label May 21, 2022
@sunfishcode
Remove ZStr and ZString.
630f88a 
Use `CStr` and `CString` instead, now that nightly has then in core and
alloc, respectively.

Fixes #336.
@sunfishcode
Enable "core_c_str" on nightly to use core::ffi::CStr.
00e49f4
@sunfishcode
Don't test --no-default-features on stable.
7ec664a 
--no-default-features disables "std", and building without "std" will
require nightly now.
@sunfishcode
CString and NulError are in alloc.
db8520a
@sunfishcode
Add comments to the relevant Cargo.toml features.
857fb7e
@sunfishcode
rustfmt
f83f5b1
@sunfishcode sunfishcode force-pushed the sunfishcode/remove-zstr branch from 503ef01 to f83f5b1 Compare May 27, 2022 04:06
cgwalters
cgwalters approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; one less string type to keep in mind is good overall.

@sunfishcode sunfishcode merged commit b437157 into main May 27, 2022
@sunfishcode sunfishcode deleted the sunfishcode/remove-zstr branch May 27, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters cgwalters approved these changes

Assignees
No one assigned
Labels
semver bump Issues that will require a semver-incompatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ZStr with CStr
2 participants
@sunfishcode @cgwalters