Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rumqttc): disable default-features for tokio-rustls #941

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jarhodes314
Copy link

This disables the default-features of the optional dependency tokio-rustls. I am attempting to build rustls with the ring backend, rather than the newly default aws-lc-sys backend. Currently the unreleased version of rumqttc enables the default features of tokio-rustls, and this is adding an unnecessary dependency on aws-lc-sys.

Type of change

Miscellaneous (related to maintenance)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

I haven't committed any changes from cargo fmt since this does not affect any rust source. It did appear to make a change in one file that I haven't touched.

I don't believe this needs a changelog entry as it shouldn't really affect downstream use of the crate, other than avoiding bringing in unnecessary dependencies. I believe anybody attempting to use rustls 0.23 in an application will need to call CryptoProvider::install_default, which necessitates a dependency on rustls anyway, which allows them to select the relevant features for their use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant