chore(rumqttc): disable default-features for tokio-rustls #941
+1
−146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the default-features of the optional dependency
tokio-rustls
. I am attempting to buildrustls
with thering
backend, rather than the newly defaultaws-lc-sys
backend. Currently the unreleased version ofrumqttc
enables the default features oftokio-rustls
, and this is adding an unnecessary dependency onaws-lc-sys
.Type of change
Miscellaneous (related to maintenance)
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.I haven't committed any changes from
cargo fmt
since this does not affect any rust source. It did appear to make a change in one file that I haven't touched.I don't believe this needs a changelog entry as it shouldn't really affect downstream use of the crate, other than avoiding bringing in unnecessary dependencies. I believe anybody attempting to use
rustls 0.23
in an application will need to callCryptoProvider::install_default
, which necessitates a dependency onrustls
anyway, which allows them to select the relevant features for their use case.